-
-
Notifications
You must be signed in to change notification settings - Fork 363
ref: Convert SentryViewHierarchyProvider to Swift #6150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6150 +/- ##
=============================================
+ Coverage 86.489% 86.719% +0.229%
=============================================
Files 435 436 +1
Lines 37046 37077 +31
Branches 15802 17400 +1598
=============================================
+ Hits 32041 32153 +112
+ Misses 4966 4879 -87
- Partials 39 45 +6
... and 22 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
00d9740 | 1223.53 ms | 1249.75 ms | 26.22 ms |
d3e7aa6 | 1226.06 ms | 1248.87 ms | 22.81 ms |
9080e6c | 1221.17 ms | 1247.87 ms | 26.71 ms |
e3767a1 | 1224.20 ms | 1257.16 ms | 32.96 ms |
4bf98bf | 1219.13 ms | 1244.50 ms | 25.38 ms |
7c7ac56 | 1225.90 ms | 1250.22 ms | 24.33 ms |
0b6776b | 1230.18 ms | 1262.06 ms | 31.88 ms |
db9572a | 1223.13 ms | 1241.60 ms | 18.47 ms |
162cd7f | 1230.59 ms | 1256.76 ms | 26.16 ms |
6ee4973 | 1228.42 ms | 1252.26 ms | 23.84 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
00d9740 | 23.75 KiB | 938.32 KiB | 914.57 KiB |
d3e7aa6 | 23.75 KiB | 913.16 KiB | 889.41 KiB |
9080e6c | 23.75 KiB | 926.80 KiB | 903.05 KiB |
e3767a1 | 23.75 KiB | 913.14 KiB | 889.39 KiB |
4bf98bf | 23.75 KiB | 919.70 KiB | 895.95 KiB |
7c7ac56 | 23.75 KiB | 902.49 KiB | 878.74 KiB |
0b6776b | 23.75 KiB | 968.23 KiB | 944.49 KiB |
db9572a | 23.75 KiB | 858.64 KiB | 834.89 KiB |
162cd7f | 23.75 KiB | 908.39 KiB | 884.64 KiB |
6ee4973 | 23.75 KiB | 896.53 KiB | 872.79 KiB |
Previous results on branch: viewHierarchySwift
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
7d3181a | 1220.55 ms | 1253.02 ms | 32.47 ms |
025f72e | 1208.65 ms | 1233.69 ms | 25.04 ms |
701652c | 1231.52 ms | 1254.45 ms | 22.93 ms |
ebfd1a0 | 1235.06 ms | 1253.19 ms | 18.13 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
7d3181a | 23.75 KiB | 971.21 KiB | 947.46 KiB |
025f72e | 23.74 KiB | 972.96 KiB | 949.21 KiB |
701652c | 23.74 KiB | 972.96 KiB | 949.22 KiB |
ebfd1a0 | 23.74 KiB | 971.03 KiB | 947.28 KiB |
27a02b4
to
c63c7eb
Compare
c63c7eb
to
8ca93c8
Compare
8ca93c8
to
a5a48cd
Compare
4f6662b
to
4467c9a
Compare
WIP
#skip-changelog
Closes #6158