Skip to content

Conversation

philipphofmann
Copy link
Member

Fixes GH-5920

#skip-changelog

@philipphofmann philipphofmann marked this pull request as ready for review September 12, 2025 04:41
Copy link

codecov bot commented Sep 12, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
3928 1 3927 52
View the top 1 failed test(s) by shortest run time
iOS_Swift_UITests.UserFeedbackUITests::testAddingAndRemovingScreenshots
Stack Traces | 0s run time
.../iOS-Swift/iOS-Swift-UITests/UserFeedbackUITests.swift:666 - Failed to tap "io.sentry.ui-test.button.get-latest-envelope" Button: No matches found for Elements matching predicate '"io.sentry.ui-test.button.get-latest-envelope" IN identifiers' from input {(

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

cursor[bot]

This comment was marked as outdated.

Copy link
Contributor

github-actions bot commented Sep 12, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1232.08 ms 1242.26 ms 10.17 ms
Size 23.75 KiB 973.33 KiB 949.59 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
fd5961e 1210.59 ms 1235.57 ms 24.98 ms
f5d202b 1237.90 ms 1259.49 ms 21.59 ms
718c372 1220.09 ms 1235.15 ms 15.06 ms
52f3b6e 1219.57 ms 1239.70 ms 20.13 ms
37183fe 1212.33 ms 1238.92 ms 26.59 ms
d66f082 1227.08 ms 1247.04 ms 19.96 ms
1b9991e 1233.45 ms 1256.61 ms 23.17 ms
9be5373 1215.92 ms 1239.44 ms 23.52 ms
87fb58a 1233.12 ms 1257.17 ms 24.04 ms
5196f0d 1213.35 ms 1231.37 ms 18.02 ms

App size

Revision Plain With Sentry Diff
fd5961e 23.74 KiB 874.07 KiB 850.32 KiB
f5d202b 23.75 KiB 904.53 KiB 880.78 KiB
718c372 23.75 KiB 920.65 KiB 896.90 KiB
52f3b6e 23.75 KiB 920.54 KiB 896.79 KiB
37183fe 23.75 KiB 913.63 KiB 889.87 KiB
d66f082 23.75 KiB 928.85 KiB 905.10 KiB
1b9991e 23.75 KiB 908.01 KiB 884.26 KiB
9be5373 23.75 KiB 866.50 KiB 842.75 KiB
87fb58a 23.75 KiB 919.91 KiB 896.16 KiB
5196f0d 23.75 KiB 876.93 KiB 853.19 KiB

Previous results on branch: ref/convert-source-wrapper-to-swift

Startup times

Revision Plain With Sentry Diff
73ae0d0 1238.27 ms 1266.47 ms 28.20 ms
74f9fe8 1222.63 ms 1258.46 ms 35.84 ms
5a52a2a 1208.00 ms 1248.63 ms 40.63 ms

App size

Revision Plain With Sentry Diff
73ae0d0 23.74 KiB 973.33 KiB 949.59 KiB
74f9fe8 23.75 KiB 971.19 KiB 947.44 KiB
5a52a2a 23.74 KiB 973.33 KiB 949.59 KiB

@philipphofmann philipphofmann marked this pull request as draft September 12, 2025 06:51
@philipphofmann
Copy link
Member Author

Back to draft as tests are failing

@philipphofmann philipphofmann marked this pull request as ready for review September 15, 2025 11:10
cursor[bot]

This comment was marked as outdated.

Copy link
Member

@philprime philprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I hope the timing corrections don't cause flakiness

@philipphofmann
Copy link
Member Author

LGTM, I hope the timing corrections don't cause flakiness

Yes, I used these these to ensure the conversion didn't break anything, but if it's going to flaky in CI, I most likely will delete the tests.

@philipphofmann philipphofmann merged commit 7bb24a2 into main Sep 16, 2025
215 of 226 checks passed
@philipphofmann philipphofmann deleted the ref/convert-source-wrapper-to-swift branch September 16, 2025 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert SentryDispatchSourceWrapper.h to Swift
2 participants