-
-
Notifications
You must be signed in to change notification settings - Fork 364
ref: Convert SentryDispatchSourceWrapper to Swift #6151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
fd5961e | 1210.59 ms | 1235.57 ms | 24.98 ms |
f5d202b | 1237.90 ms | 1259.49 ms | 21.59 ms |
718c372 | 1220.09 ms | 1235.15 ms | 15.06 ms |
52f3b6e | 1219.57 ms | 1239.70 ms | 20.13 ms |
37183fe | 1212.33 ms | 1238.92 ms | 26.59 ms |
d66f082 | 1227.08 ms | 1247.04 ms | 19.96 ms |
1b9991e | 1233.45 ms | 1256.61 ms | 23.17 ms |
9be5373 | 1215.92 ms | 1239.44 ms | 23.52 ms |
87fb58a | 1233.12 ms | 1257.17 ms | 24.04 ms |
5196f0d | 1213.35 ms | 1231.37 ms | 18.02 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
fd5961e | 23.74 KiB | 874.07 KiB | 850.32 KiB |
f5d202b | 23.75 KiB | 904.53 KiB | 880.78 KiB |
718c372 | 23.75 KiB | 920.65 KiB | 896.90 KiB |
52f3b6e | 23.75 KiB | 920.54 KiB | 896.79 KiB |
37183fe | 23.75 KiB | 913.63 KiB | 889.87 KiB |
d66f082 | 23.75 KiB | 928.85 KiB | 905.10 KiB |
1b9991e | 23.75 KiB | 908.01 KiB | 884.26 KiB |
9be5373 | 23.75 KiB | 866.50 KiB | 842.75 KiB |
87fb58a | 23.75 KiB | 919.91 KiB | 896.16 KiB |
5196f0d | 23.75 KiB | 876.93 KiB | 853.19 KiB |
Previous results on branch: ref/convert-source-wrapper-to-swift
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
73ae0d0 | 1238.27 ms | 1266.47 ms | 28.20 ms |
74f9fe8 | 1222.63 ms | 1258.46 ms | 35.84 ms |
5a52a2a | 1208.00 ms | 1248.63 ms | 40.63 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
73ae0d0 | 23.74 KiB | 973.33 KiB | 949.59 KiB |
74f9fe8 | 23.75 KiB | 971.19 KiB | 947.44 KiB |
5a52a2a | 23.74 KiB | 973.33 KiB | 949.59 KiB |
Back to draft as tests are failing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I hope the timing corrections don't cause flakiness
Yes, I used these these to ensure the conversion didn't break anything, but if it's going to flaky in CI, I most likely will delete the tests. |
Fixes GH-5920
#skip-changelog