Skip to content

Conversation

noahsmartin
Copy link
Contributor

#skip-changelog

Copy link

codecov bot commented Sep 12, 2025

❌ 19 Tests Failed:

Tests completed Failed Passed Skipped
3228 19 3209 16
View the top 3 failed test(s) by shortest run time
SentryFileManagerTests::testGetAllEnvelopesAreSortedByDateAscending
Stack Traces | 0s run time
Restarting after unexpected exit, crash, or test timeout in SentryFileManagerTests.testGetAllEnvelopesAreSortedByDateAscending(); summary will include totals from previous launches.
SentryFileManagerTests::testMigrateSessionInit_FailToLoadEnvelope
Stack Traces | 0s run time
Restarting after unexpected exit, crash, or test timeout in SentryFileManagerTests.testMigrateSessionInit_FailToLoadEnvelope(); summary will include totals from previous launches.
SentryFileManagerTests::testMigrateSessionInit_IsInMiddle
Stack Traces | 0s run time
Restarting after unexpected exit, crash, or test timeout in SentryFileManagerTests.testMigrateSessionInit_IsInMiddle(); summary will include totals from previous launches.
SentryFileManagerTests::testMigrateSessionInit_MovesInitFlagOnlyToFirstSessionUpdate
Stack Traces | 0s run time
Restarting after unexpected exit, crash, or test timeout in SentryFileManagerTests.testMigrateSessionInit_MovesInitFlagOnlyToFirstSessionUpdate(); summary will include totals from previous launches.
SentryFileManagerTests::testMigrateSessionInit_SessionUpdateIsLast
Stack Traces | 0s run time
Restarting after unexpected exit, crash, or test timeout in SentryFileManagerTests.testMigrateSessionInit_SessionUpdateIsLast(); summary will include totals from previous launches.
SentryFileManagerTests::testMigrateSessionInit_SessionUpdateIsSecond
Stack Traces | 0s run time
Restarting after unexpected exit, crash, or test timeout in SentryFileManagerTests.testMigrateSessionInit_SessionUpdateIsSecond(); summary will include totals from previous launches.
SentryTests.SentryFileManagerTests::testAppHangEventExists_WithGarbage_ReturnsTrue
Stack Traces | 0s run time
.../SentryTests/Helper/SentryFileManagerTests.swift:871 - XCTAssertTrue failed
SentryTests.SentryFileManagerTests::testDefaultMaxEnvelopes
Stack Traces | 0s run time
.../SentryTests/Helper/SentryFileManagerTests.swift:344 - XCTAssertEqual failed: ("30") is not equal to ("1")
SentryTests.SentryFileManagerTests::testDefaultMaxEnvelopes_CallsEnvelopeItemDeleted
Stack Traces | 0s run time
.../SentryTests/Helper/SentryFileManagerTests.swift:360 - XCTAssertEqual failed: ("4") is not equal to ("33")
SentryTests.SentryFileManagerTests::testDeleteAppState_WhenFileLocked_DontCrash
Stack Traces | 0s run time
.../SentryTests/Helper/SentryFileManagerTests.swift:748 - XCTAssertNotNil failed
SentryTests.SentryFileManagerTests::testGetAllEnvelopesAreSortedByDateAscending
Stack Traces | 0s run time
.../SentryTests/Helper/SentryFileManagerTests.swift:512 - XCTAssertEqual failed: ("30") is not equal to ("10")
SentryTests.SentryFileManagerTests::testGetOldestEnvelope
Stack Traces | 0s run time
.../SentryTests/Helper/SentryFileManagerTests.swift:526 - XCTAssertEqual failed: ("Optional(333ad66c514848dcbc1407a6c53be926)") is not equal to ("Optional(0b65fa8a18d5462a82856b10d6983fe6)")
SentryTests.SentryFileManagerTests::testMaxEnvelopesSet
Stack Traces | 0s run time
.../SentryTests/Helper/SentryFileManagerTests.swift:399 - XCTAssertEqual failed: ("15") is not equal to ("0")
SentryTests.SentryFileManagerTests::testMigrateSessionInit_DoesNotCallEnvelopeItemDeleted
Stack Traces | 0s run time
.../SentryTests/Helper/SentryFileManagerTests.swift:500 - XCTAssertEqual failed: ("0") is not equal to ("31")
SentryTests.SentryFileManagerTests::testStoreDeleteTimezoneOffset_WhenFileLocked_DontCrash
Stack Traces | 0s run time
.../SentryTests/Helper/SentryFileManagerTests.swift:803 - XCTAssertNotNil failed
SentryTests.SentryFileManagerTests::testStore_WhenFileImmutable_AppStateIsNotOverwritten
Stack Traces | 0s run time
.../SentryTests/Helper/SentryFileManagerTests.swift:1559 - XCTAssertEqual failed: ("Optional(<Sentry.SentryAppState: 0x600003315e00>)") is not equal to ("Optional(<Sentry.SentryAppState: 0x600003315f90>)")
SentryTests.SentryFileManagerTests::testStore_WhenFileImmutable_TimezoneOffsetIsNotOverwritten
Stack Traces | 0s run time
.../SentryTests/Helper/SentryFileManagerTests.swift:794 - XCTAssertEqual failed: ("Optional(9600)") is not equal to ("Optional(7200)")
SentryTests.SentryHttpTransportTests::testCacheFull_RecordsLostEvent
Stack Traces | 0s run time
.../SentryTests/Networking/SentryHttpTransportTests.swift:665 - XCTAssertEqual failed: ("Optional(1)") is not equal to ("Optional(31)")
SentryTests.SentryHttpTransportTests::testCacheFull_RecordsLostSpans
Stack Traces | 0s run time
.../SentryTests/Networking/SentryHttpTransportTests.swift:685 - XCTAssertEqual failed: ("Optional(1)") is not equal to ("Optional(31)")

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@noahsmartin noahsmartin force-pushed the fileManagerSwift branch 6 times, most recently from ba7a683 to 8de6ab1 Compare September 18, 2025 21:26
Copy link
Contributor

🚨 Detected changes in high risk code 🚨

High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:

  • Sources/Sentry/SentryFileManager.m

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant