-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update RN Custom Metrics to use Sentry.setMeasurement
#12496
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
I reported the origin issue - confirming that this fixes it 👍 Thanks! |
@recurser Thank you for the confirmation. |
@@ -6,7 +6,12 @@ sidebar_order: 20 | |||
|
|||
Sentry's SDKs support sending performance metrics data to Sentry. These are numeric values attached to transactions that are aggregated and displayed in Sentry. | |||
|
|||
<PlatformContent includePath="performance/automatic-performance-metrics" /> | |||
If configured, the React Native SDK automatically collects the following performance metrics: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If configured, the React Native SDK automatically collects the following performance metrics: | |
The React Native SDK automatically collects the following performance metrics: |
If configured, the React Native SDK automatically collects the following performance metrics: | ||
|
||
- <PlatformLink to="/tracing/instrumentation/automatic-instrumentation/#app-start-instrumentation"> Cold and warm app start time </PlatformLink> | ||
. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
. |
- <PlatformLink to="/tracing/instrumentation/automatic-instrumentation/#app-start-instrumentation"> Cold and warm app start time </PlatformLink> | ||
. | ||
- <PlatformLink to="/tracing/instrumentation/automatic-instrumentation/#slow-and-frozen-frames"> Slow and frozen frame rendering </PlatformLink> | ||
. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
DESCRIBE YOUR PR
Tell us what you're changing and why. If your PR resolves an issue, please link it so it closes automatically.
Fixes getsentry/sentry-react-native#4488
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES