Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(js): Streamline links for explanations about tracing sampling #13154

Merged
merged 1 commit into from
Mar 31, 2025

Conversation

mydea
Copy link
Member

@mydea mydea commented Mar 28, 2025

Since we have a dedicated page about this, we should link there instead of to the generic options, which have less information than other places.

Generally, I wonder if it really makes sense to have the "Configure Sample Rate" page under "Set Up Tracing" as well as the "Sampling" page under configuration, which have almost-but-not-quite the same information as of now 🤔 IMHO one of these should stay and the other should go (personally I would vote for configuration/sampling and linking there from the tracing docs)

@mydea mydea requested review from lforst and codyde March 28, 2025 14:48
@mydea mydea self-assigned this Mar 28, 2025
Copy link

vercel bot commented Mar 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 28, 2025 3:02pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Mar 28, 2025 3:02pm
develop-docs ⬜️ Ignored (Inspect) Mar 28, 2025 3:02pm

Copy link

codecov bot commented Mar 28, 2025

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.6MB -9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.44MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.58MB -0.0%
../instrumentation.js -3 bytes 910.48kB -0.0%
9523.js -3 bytes 886.53kB -0.0%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 869.55kB -0.0%
static/chunks/4612-*.js -3 bytes 398.04kB -0.0%
server/middleware-*.js 5.55kB 6.55kB 555.3% ⚠️
server/middleware-*.js -5.55kB 1.0kB -84.74%
static/_VGu3mP57nLSOe3Q5PcW9/_buildManifest.js (New) 578 bytes 578 bytes 100.0% 🚀
static/_VGu3mP57nLSOe3Q5PcW9/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/YSFqs7Z_VFtrtAhNLHlnO/_buildManifest.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/YSFqs7Z_VFtrtAhNLHlnO/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

@codyde
Copy link
Contributor

codyde commented Mar 29, 2025

Since we have a dedicated page about this, we should link there instead of to the generic options, which have less information than other places.

Generally, I wonder if it really makes sense to have the "Configure Sample Rate" page under "Set Up Tracing" as well as the "Sampling" page under configuration, which have almost-but-not-quite the same information as of now 🤔 IMHO one of these should stay and the other should go (personally I would vote for configuration/sampling and linking there from the tracing docs)

Yeah - this ones a tough one. Dhrumil had asked (and I agreed) to have a dedicated page for it within the tracing section because we def expect people to need to sample out their traces (high volume transactions and all), but to your point - it's valuable info across the board for other sample areas too.

Its something we could leave in place and track, to see how much traffic hits and where user volume lands?

Either way - PR looks good; thanks for helping clean this up a bit. Approving for my side.

Copy link
Contributor

@codyde codyde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mydea mydea merged commit 428ab24 into master Mar 31, 2025
11 checks passed
@mydea mydea deleted the fn/rendundant-tracing-options branch March 31, 2025 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants