Skip to content

docs(insights): document mobile session health tab #13344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Apr 15, 2025

Conversation

michellewzhang
Copy link
Member

@michellewzhang michellewzhang commented Apr 10, 2025

also adds it to the early adopter features page.

to view just the mobile changes: 8891da8

screenshots are taken from sentry-sdks.

branched off of #13340 since it reuses some of the same components

SCR-20250410-nvce

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link

vercel bot commented Apr 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2025 9:45pm
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2025 9:45pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Apr 15, 2025 9:45pm

@michellewzhang michellewzhang requested review from a team, bcoe, bruno-garcia and jas-kas April 10, 2025 22:41

This comment was marked as off-topic.

@bruno-garcia
Copy link
Member

didn't read it yet but CI says it has 404's, CI issue?

@ryan953
Copy link
Member

ryan953 commented Apr 11, 2025

didn't read it yet but CI says it has 404's, CI issue?

i've seen those 404 issues in a bunch of docs PRs lately, none of them look like links that are part of this PR so i'd ignore it

@michellewzhang
Copy link
Member Author

didn't read it yet but CI says it has 404's, CI issue?

yes, it was an issue (unrelated to my PR) that's been ongoing. @chargome fixed recently so i rebased - should be fine now

Copy link
Member

@kahest kahest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you!

Copy link
Contributor

@sfanahata sfanahata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Doesn't look like the 404s are on any of the files you're updating so agree that it's probably fine to push forward. That error does look different from the one we saw last week though, @chargome. Those issues were also resolved last week.

@michellewzhang michellewzhang force-pushed the mz/mobile-session-health-docs branch 2 times, most recently from 35addf4 to d96a071 Compare April 14, 2025 22:16
@michellewzhang michellewzhang force-pushed the mz/mobile-session-health-docs branch from b567c0e to cd5343a Compare April 15, 2025 21:15
@michellewzhang michellewzhang merged commit 2613b1e into master Apr 15, 2025
15 checks passed
@michellewzhang michellewzhang deleted the mz/mobile-session-health-docs branch April 15, 2025 21:45
bitsandfoxes pushed a commit that referenced this pull request Apr 24, 2025
* docs(insights): document frontend session health tab

* fix overview img

* wording

* fix another img

* update unhealthy sessions

* link

* make reusable

* refactor

* pr review

* jasmin pr review

* jasmin pr review pt 2

* wording

* docs(insights): document mobile session health tab

* wording

* pr review pt 1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants