Skip to content

feat: Inline onboarding product options syntax #13361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 16, 2025
Merged

feat: Inline onboarding product options syntax #13361

merged 6 commits into from
Apr 16, 2025

Conversation

a-hariti
Copy link
Collaborator

@a-hariti a-hariti commented Apr 11, 2025 •
edited
Loading

closes #12955

I migrated Hono to the new syntax as an example

more context on the issue 👆

@vercel Vercel
Copy link

vercel bot commented Apr 11, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 14, 2025 3:42pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Apr 14, 2025 3:42pm
develop-docs ⬜️ Ignored (Inspect) Visit Preview Apr 14, 2025 3:42pm

@codecov Codecov
Copy link

codecov bot commented Apr 11, 2025 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 537 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 11.13MB 504 bytes (0.0%) ⬆️
sentry-docs-client-array-push 9.47MB 33 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 868.7kB -0.0%
static/css/*.css 39 bytes 18.7kB 0.21%
static/chunks/8165-*.js -3 bytes 410.1kB -0.0%
static/URJq1_JomvdCOVT-*.js (New) 77 bytes 77 bytes 100.0% 🚀
static/URJq1_JomvdCOVT-*.js (New) 578 bytes 578 bytes 100.0% 🚀
static/ZaWzhswmECXOgdma5xsug/_buildManifest.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/ZaWzhswmECXOgdma5xsug/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.75MB -0.0%
../instrumentation.js -3 bytes 1.08MB -0.0%
9523.js -3 bytes 1.05MB -0.0%
9567.js 513 bytes 19.24kB 2.74%

Files in 9567.js:

  • ./src/mdx.ts → Total Size: 18.16kB

  • ./src/rehype-onboarding-lines.js → Total Size: 4.42kB

@a-hariti a-hariti requested review from chargome and adinauer April 11, 2025 13:48
chargome
chargome reviewed Apr 14, 2025
View reviewed changes
Copy link
Member

@chargome chargome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really cool @a-hariti 🥇

adinauer
adinauer approved these changes Apr 15, 2025
View reviewed changes
Copy link
Member

@adinauer adinauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This looks much easier to maintain 🎉

@a-hariti a-hariti marked this pull request as ready for review April 15, 2025 13:03
@a-hariti a-hariti changed the title Improve product options syntax feat: Inline onboarding product options syntax Apr 16, 2025
@a-hariti a-hariti merged commit cda95aa into master Apr 16, 2025
13 checks passed
@a-hariti a-hariti deleted the new-product-options-syntax branch April 16, 2025 10:38
@a-hariti a-hariti mentioned this pull request Apr 16, 2025
Merged
a-hariti added a commit that referenced this pull request Apr 16, 2025
@a-hariti
refactor: migrate python and related guides to the inline product opt…
353bc2b 
…ions syntax

related to #13361
@a-hariti a-hariti mentioned this pull request Apr 16, 2025
Merged
a-hariti added a commit that referenced this pull request Apr 16, 2025
@a-hariti
refactor: migrate Golang and related guides to inline product options
73b320a 
sytnax

related to #13361
@a-hariti a-hariti mentioned this pull request Apr 16, 2025
Merged
This was referenced Apr 16, 2025
Merged
Merged
Merged
a-hariti added a commit that referenced this pull request Apr 17, 2025
@a-hariti
refactor: migrate Python and related guides to inline product options…
6f44215 
… syntax (#13412)

* refactor: migrate python and related guides to inline product options syntax

related to #13361
This was referenced Apr 17, 2025
Merged
Merged
Merged
@chargome chargome mentioned this pull request Apr 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adinauer adinauer adinauer approved these changes

@chargome chargome chargome approved these changes

@stephanie-anderson stephanie-anderson Awaiting requested review from stephanie-anderson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New way of marking product feature related code snippet sections
3 participants
@a-hariti @adinauer @chargome