-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
ref(platform): Further streamlining of sidebar nav code #13370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Bundle ReportChanges will decrease total bundle size by 1.18kB (-0.01%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-client-array-pushAssets Changed:
Files in
Files in
view changes for bundle: sentry-docs-server-cjsAssets Changed:
Files in
App Routes Affected:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
</SidebarLink> | ||
</ul> | ||
<hr /> | ||
<div className={`${styles.toc} mt-3`}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does styles.toc
actually exist?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch! removed this, and fixed the styling to be bold as well there in 778c708
This is a further refactor/streamlining of the sidebar components.
This is preparation to allow easier exploration/experimentation of new sidebar designs, which right now was a bit tricky because the code was spread all over the place.
This PR:
sidebar
folder<SidebarLink>
everywhere, which also encapsulates the respective styles needed<CollapsibleSidebarLink>
component to handle the DynamicNav use case (client component)<SidebarSeparator>
component to allow specific styling of this vs. implicit hierarchy styling of<hr>
SidebarLinks
toSidebarNavigation
for better clarity/to avoid confusing withSidebarLink