Skip to content

Conversation

markushi
Copy link
Member

DESCRIBE YOUR PR

Add docs for getsentry/sentry-java#4671

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

Copy link

vercel bot commented Sep 10, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
sentry-docs Ready Ready Preview Comment Sep 10, 2025 8:34am
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
develop-docs Ignored Ignored Sep 10, 2025 8:34am

@codeowner-assignment codeowner-assignment bot requested review from a team September 10, 2025 08:08
@cleptric
Copy link
Member

Starting from version 8.22.0, the Java SDK also supports the W3C traceparent HTTP header
Let's make it clear that this is only for outgoing http requests.

Comment on lines +67 to +71
## W3C Traceparent Header Support

Starting from version 8.22.0, the Android SDK also supports the W3C `traceparent` HTTP header. This header follows the W3C Trace Context specification and provides interoperability with other tracing systems that support this standard.

To enable W3C `traceparent` header propagation, set the [`propagateTraceparent`](/platforms/android/configuration/options/#propagate-traceparent) option to `true`. When enabled, the `traceparent` header will be propagated alongside the `sentry-trace` and `baggage` headers to outgoing HTTP requests. Like the other headers, it's attached to all requests by default, or only to requests matching your `tracePropagationTargets` configuration if you've specified one.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potential bug: The Android documentation for propagateTraceparent is missing the required CORS configuration for the traceparent header, which will cause cross-origin requests to fail.
  • Description: The Android documentation for the new propagateTraceparent feature omits the requirement to add the traceparent header to the backend's Access-Control-Allow-Headers CORS configuration. When users enable this feature for cross-origin requests, their backend services will reject the requests, causing application failures. This critical information is present in the JavaScript SDK documentation but is missing for Android, creating a functional gap for users of the feature.

  • Suggested fix: Update the Android documentation to include the CORS requirement for the traceparent header. Add an inline warning in the new traceparent section and update the existing 'Dealing with CORS Issues' page to include traceparent in the Access-Control-Allow-Headers example.
    severity: 0.75, confidence: 0.95

Did we get this right? 👍 / 👎 to inform future reviews.

Comment on lines +67 to +71

Starting from version 8.22.0, the Java SDK also supports the W3C `traceparent` HTTP header. This header follows the W3C Trace Context specification and provides interoperability with other tracing systems that support this standard.

To enable W3C `traceparent` header propagation, set the [`propagateTraceparent`](/platforms/java/configuration/options/#propagate-traceparent) option to `true`. When enabled, the `traceparent` header will be propagated alongside the `sentry-trace` and `baggage` headers to outgoing HTTP requests. Like the other headers, it's attached to all requests by default, or only to requests matching your `tracePropagationTargets` configuration if you've specified one.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potential bug: The Java documentation for propagateTraceparent is missing the required CORS configuration for the traceparent header, which will cause cross-origin requests to fail.
  • Description: The Java documentation for the new propagateTraceparent feature omits the requirement to add the traceparent header to the backend's Access-Control-Allow-Headers CORS configuration. When users enable this feature for cross-origin requests, their backend services will reject the requests, causing application failures. This critical information is present in the JavaScript SDK documentation but is missing for Java, creating a functional gap for users of the feature.

  • Suggested fix: Update the Java documentation to include the CORS requirement for the traceparent header. Add an inline warning in the new traceparent section and update the existing 'Dealing with CORS Issues' page to include traceparent in the Access-Control-Allow-Headers example.
    severity: 0.75, confidence: 0.95

Did we get this right? 👍 / 👎 to inform future reviews.

Copy link

codecov bot commented Sep 10, 2025

Bundle Report

Changes will increase total bundle size by 6.27kB (0.03%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-client-array-push 9.91MB -6 bytes (-0.0%) ⬇️
sentry-docs-server-cjs 12.61MB 6.28kB (0.05%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.78MB -0.0%
../instrumentation.js -3 bytes 1.1MB -0.0%
9523.js -3 bytes 1.08MB -0.0%
../app/[[...path]]/page.js.nft.json 2.1kB 804.22kB 0.26%
../app/platform-redirect/page.js.nft.json 2.1kB 804.14kB 0.26%
../app/sitemap.xml/route.js.nft.json 2.1kB 801.61kB 0.26%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 882.71kB -0.0%
static/chunks/8321-*.js -3 bytes 425.87kB -0.0%
static/o0y2oWxA4SmWXjVHblPOW/_buildManifest.js (New) 684 bytes 684 bytes 100.0% 🚀
static/o0y2oWxA4SmWXjVHblPOW/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/r8TLlYzxXkaNUPzMY3JYM/_buildManifest.js (Deleted) -684 bytes 0 bytes -100.0% 🗑️
static/r8TLlYzxXkaNUPzMY3JYM/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

Copy link
Contributor

@sfanahata sfanahata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markushi This all looks good. Does it make sense to link to info on W3C in these documents? I don't know too much about java, so not sure if this is base knowledge, or helpful for folks to get context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants