feat: http client integration #876
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #876 +/- ##
==========================================
+ Coverage 82.85% 83.06% +0.21%
==========================================
Files 55 56 +1
Lines 4619 4677 +58
==========================================
+ Hits 3827 3885 +58
Misses 636 636
Partials 156 156 ☔ View full report in Codecov by Sentry. |
|
@aldy505 We should document this (in _examples, and perhaps sentry-docs?), and also update changelog accordingly. |
httpclient/sentryhttpclient.go
Outdated
|
|
||
| span := sentry.StartSpan(ctx, "http.client", sentry.WithTransactionName(fmt.Sprintf("%s %s", request.Method, cleanRequestURL))) | ||
|
|
||
| for k, v := range s.tags { |
There was a problem hiding this comment.
Could we just set the span.Tags instead of ranging through these, and setting one by one?
This is the 'right' way to do it, but it involves checking for nil map and dealing with mutex.
There was a problem hiding this comment.
Lol good catch. I was copying directly from this PR aldy505/sentry-integration#1
httpclient/sentryhttpclient.go
Outdated
| span := sentry.StartSpan(ctx, "http.client", sentry.WithTransactionName(fmt.Sprintf("%s %s", request.Method, cleanRequestURL))) | ||
| span.Tags = s.tags | ||
| defer span.Finish() |
There was a problem hiding this comment.
We do not want to always start transactions here. If one already exists, start a child span.
There was a problem hiding this comment.
Just to be clear: http.client spans should only created if there is any parent span?
There was a problem hiding this comment.
Yes, Sentry does not work well with these kind of single span transactions. We can revisit this once span streaming is fully supported in the product, but this will take a few months.
There was a problem hiding this comment.
https://sentry.io/insights/http/ should also work with these spans fwiw, docs are here.
There was a problem hiding this comment.
*which you already mentioned in the PR description, nvm
There was a problem hiding this comment.
Another question (unrelated): Does that also affects all the span op within the insights module? Meaning not only http.client, but db.sql and messaging.* also counts?
There was a problem hiding this comment.
I guess technically we extract all the required fields from a transaction and store it into the span data set, though this is not how these modules where initially designed to work.
An effort to implement this: https://develop.sentry.dev/sdk/telemetry/traces/modules/requests/
Since we already have tracing without performance, this should be good to go.