Add E2E tests for Logback #4599
Open
+149
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adinauer
requested review from
romtsn,
stefanosiano,
markushi and
lcian
as code owners
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| @@ -0,0 +1,67 @@ | |||
| package io.sentry.systemtest.io.sentry.systemtest | |||
There was a problem hiding this comment.
Bug: Duplicate Package Declaration Causes Compilation Issues
The package declaration package io.sentry.systemtest.io.sentry.systemtest contains a duplicated segment. It should be package io.sentry.systemtest to match the file path, as the current declaration will cause compilation errors or incorrect package structure.
Performance metrics 🚀
|
lcian
approved these changes
Aug 4, 2025
Comment on lines
+25
to
+31
| kotlinOptions.jvmTarget = JavaVersion.VERSION_17.toString() | ||
| } | ||
|
|
||
| tasks.withType<KotlinCompile>().configureEach { | ||
| kotlinOptions { | ||
| freeCompilerArgs = listOf("-Xjsr305=strict") | ||
| jvmTarget = JavaVersion.VERSION_17.toString() |
There was a problem hiding this comment.
Is there a reason to set the jvmTarget twice on the kotlinOptions, or are the configurations redundant?
The question applies to the other E2E PRs as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#skip-changelog
📜 Description
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps