fix(mongo): rewrite Buffer as ? during serialization #14071
Merged
+122
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
mydea
approved these changes
Oct 29, 2024
mydea
reviewed
Oct 29, 2024
Comment on lines
+55
to
+59
| let isBuffer = false; | ||
| if (typeof Buffer !== 'undefined') { | ||
| isBuffer = Buffer.isBuffer(value); | ||
| } | ||
| return isBuffer; |
There was a problem hiding this comment.
I don't think this is necessary, all our node versions should support this so let's just check normally here :)
|
Have we considered trying to upstream this into OTel's mongo instrumentation? Seems like a nicer default than what they've got, and it helps share the maintenance of the code. (Doesn't have to block this PR though, we can always take it back out if/when it gets upstreamed). |
|
@mjq yes, I will upstream and keep an eye on when we can roll this code back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Buffer, which Mongoose uses some instances rather than astringserializes as{"0": "?", "1": "?", "2": "?"}.yarn lint) & (yarn test).