-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
fix(browser): Improve navigation vs. redirect detection #17275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Lms24
wants to merge
3
commits into
develop
Choose a base branch
from
lms/fix-browser-redirect-threshold
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+310
−84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a862c31
to
1dbc1af
Compare
size-limit report 📦
|
mydea
reviewed
Aug 4, 2025
// Reset the last interaction timestamp since we now start a new navigation. | ||
// Any subsequent navigation span starts could again be a redirect, so we | ||
// should reset our heuristic detectors. | ||
lastInteractionTimestamp = undefined; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OMG, that makes a lot of sense 😅
mydea
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to improve our
navigation
root vs.navigation.redirect
child span detection logic in the defaultbrowserTracingIntegration
:I was a bit confused about the previous logic of interaction timestamps, including the tests. So in attempt to clear it up, I also renamed and slightly reworked the tests. Also added a couple of new ones, including one that tests a series of redirects and navigations. Chances are though, that I'm missing an important detail why we reused interaction timestamps prior to the last root span.
First part of #17282. From this issue, we should still consider bringing this functionality to all BT integrations but one step at a time :)