Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(publish): fetch javadoc for 2 digit release numbers #282

Merged
merged 3 commits into from
Oct 8, 2024

Conversation

buenaflor
Copy link
Contributor

@buenaflor buenaflor commented Oct 8, 2024

📜 Description

Current way of fetching the javadoc only works on 1 digit e.g 0.9.0 but not 2 digits 0.10.0

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.

#skip-changelog

@buenaflor buenaflor requested a review from romtsn as a code owner October 8, 2024 18:58
@buenaflor buenaflor changed the title fix(publish): javadoc for 2 digit release numbers fix(publish): fetch javadoc for 2 digit release numbers Oct 8, 2024
Comment on lines -6 to -8
private object Consts {
val taskRegex = Regex("(.*)DistZip")
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dead code, suprised detekt doesn't detect this

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesnt detekt 😜

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.44%. Comparing base (2d92948) to head (c2aa95a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #282   +/-   ##
=======================================
  Coverage   76.44%   76.44%           
=======================================
  Files          39       39           
  Lines         607      607           
  Branches       86       86           
=======================================
  Hits          464      464           
  Misses         97       97           
  Partials       46       46           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@buenaflor buenaflor merged commit 887ef60 into main Oct 8, 2024
13 of 17 checks passed
@buenaflor buenaflor deleted the fix/publish-javadoc branch October 8, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants