Skip to content

Move replay options out of experimental #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 16, 2025
Merged

Move replay options out of experimental #367

merged 6 commits into from
Apr 16, 2025

Conversation

buenaflor
Copy link
Contributor

📜 Description

💡 Motivation and Context

Closes #348

💚 How did you test it?

📝 Checklist

You have to check all boxes before merging:

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.

🔮 Next steps

@buenaflor buenaflor requested a review from romtsn as a code owner April 16, 2025 14:11
Copy link
Contributor

github-actions bot commented Apr 16, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 9d17fa8

Copy link

codecov bot commented Apr 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.87%. Comparing base (b0fba0e) to head (9d17fa8).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #367   +/-   ##
=======================================
  Coverage   79.87%   79.87%           
=======================================
  Files          44       44           
  Lines         810      810           
  Branches      108      108           
=======================================
  Hits          647      647           
  Misses        107      107           
  Partials       56       56           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@buenaflor buenaflor enabled auto-merge (squash) April 16, 2025 22:27
@buenaflor buenaflor merged commit 90c25c6 into main Apr 16, 2025
15 checks passed
@buenaflor buenaflor deleted the feat/ga-replay branch April 16, 2025 22:32
@maxkomarychev
Copy link

Hi 👋 .

What's the ETA to get this released as a new version? I'm currently unable to use latest ios sdk (8.49.0) with KMM package 0.11.0 due to the crash and I'm not able to downgrade ios sdk below 8.46.0 because of the compatibility with xcode 16.3.

*** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '-[Sentry.SentryExperimentalOptions setSessionReplay:]: unrecognized selector sent to instance 0x60000000d650'

@buenaflor
Copy link
Contributor Author

buenaflor commented Apr 22, 2025

@maxkomarychev hey, at the latest end of this week but I'll try to get to a release today or tomorrow. Sorry for the inconvenience.

Meanwhile if you cannot work with anything at all I'd suggest using something like https://www.xcodes.app/ to manage xcode versions so you can downgrade temporarily

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Session Replay GA
3 participants