Deps: Update Kotlin to 2.1.21
#389
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #389 +/- ##
==========================================
- Coverage 79.97% 79.75% -0.23%
==========================================
Files 44 44
Lines 814 815 +1
Branches 110 110
==========================================
- Hits 651 650 -1
- Misses 107 109 +2
Partials 56 56 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Setting it to draft, lots of problems with the K2 compiler right now |
buenaflor
commented
Jun 27, 2025
Comment on lines
46
to
-47
| public var contexts: Map<String, Any> = mapOf() | ||
| internal set |
There was a problem hiding this comment.
internal set was what messed up the K2 compiler when compiling for native targets. admittedly I have no idea why but it compiles without it 😅
buenaflor
commented
Jun 27, 2025
| @@ -31,5 +30,5 @@ internal fun wrapUnhandledExceptionHook(hook: (Throwable) -> Unit) { | |||
| prevHook.value?.invoke(it) | |||
| terminateWithUnhandledException(it) | |||
| } | |||
| prevHook.value = setUnhandledExceptionHook(wrappedHook.freeze()) | |||
There was a problem hiding this comment.
freeze() is deprecated / not needed anymore in this kotlin version
|
@romtsn ready for review when you hve time 🙏 |
romtsn
reviewed
Jul 1, 2025
romtsn
reviewed
Jul 1, 2025
romtsn
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kotlin
2.1.21adds support for Xcode 16.3 and higher so this is importantAlso update the compose version for the sample apps