-
Notifications
You must be signed in to change notification settings - Fork 536
Enable tracing without performance by default #4240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable tracing without performance by default #4240
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## potel-base #4240 +/- ##
==============================================
- Coverage 83.58% 83.57% -0.01%
==============================================
Files 144 144
Lines 14661 14663 +2
Branches 2323 2324 +1
==============================================
+ Hits 12254 12255 +1
- Misses 1688 1690 +2
+ Partials 719 718 -1
|
d5b8581
to
d47e097
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💪🏻
Oh yeah one thing -- please also add this to the MIGRATION_GUIDE @antonpirker |
Changing the default of
traces_sample_rate
to0
. This means incoming traces will be continued, but we will not start traces on our own. (It used to be set to: never start or continue traces by default)Refs #4102