Skip to content

Enable tracing without performance by default #4240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Apr 9, 2025

Conversation

antonpirker
Copy link
Member

@antonpirker antonpirker commented Apr 3, 2025

Changing the default of traces_sample_rate to 0. This means incoming traces will be continued, but we will not start traces on our own. (It used to be set to: never start or continue traces by default)

Refs #4102

@antonpirker antonpirker requested a review from a team as a code owner April 3, 2025 15:18
@antonpirker antonpirker marked this pull request as draft April 3, 2025 15:18
Copy link

codecov bot commented Apr 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.57%. Comparing base (9977769) to head (28c0a08).
Report is 3 commits behind head on potel-base.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@              Coverage Diff               @@
##           potel-base    #4240      +/-   ##
==============================================
- Coverage       83.58%   83.57%   -0.01%     
==============================================
  Files             144      144              
  Lines           14661    14663       +2     
  Branches         2323     2324       +1     
==============================================
+ Hits            12254    12255       +1     
- Misses           1688     1690       +2     
+ Partials          719      718       -1     
Files with missing lines Coverage Δ
sentry_sdk/consts.py 99.51% <ø> (ø)

... and 3 files with indirect coverage changes

@antonpirker antonpirker force-pushed the antonpirker/potel/trace-propagation-tests branch from d5b8581 to d47e097 Compare April 9, 2025 07:52
@antonpirker antonpirker changed the title [WIP] Testing trace propagation in POTel Enable tracing without performance by default Apr 9, 2025
Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪🏻

@sentrivana
Copy link
Contributor

Oh yeah one thing -- please also add this to the MIGRATION_GUIDE @antonpirker

@antonpirker antonpirker merged commit e8f99b3 into potel-base Apr 9, 2025
112 checks passed
@antonpirker antonpirker deleted the antonpirker/potel/trace-propagation-tests branch April 9, 2025 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants