-
Notifications
You must be signed in to change notification settings - Fork 557
Use context
for logging
extra
#4694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: potel-base
Are you sure you want to change the base?
Use context
for logging
extra
#4694
Conversation
❌ 17 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
DB / lint failures are unrelated (fixed on master, but not yet on potel-base) |
try: | ||
1 / 0 | ||
except ZeroDivisionError as e: | ||
capture_exception(e) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Test Coverage Loss for Sensitive Data Scrubbing
The test_extra_scrubbing
test (formerly test_breadcrumb_extra_scrubbing
) lost critical coverage for sensitive data scrubbing. It no longer verifies that logging extra data is scrubbed, especially since this data now goes to event["contexts"]["logging"]
. This gap could allow sensitive information like passwords or auth tokens to leak. The test also removed coverage for breadcrumb scrubbing and _meta
assertions.
We're moving away from using
extra
on the event in favor ofcontexts
Ref #4687