Improved devcontainer setup with e2e test mini infra #2672
+2,332
−79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2672 +/- ##
==========================================
+ Coverage 97.39% 97.41% +0.01%
==========================================
Files 135 135
Lines 5229 5229
==========================================
+ Hits 5093 5094 +1
+ Misses 136 135 -1
🚀 New features to boost your workflow:
|
solnic
force-pushed
the
e2e-test-setup
branch
24 times, most recently
from
9c29d73 to
1830579
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
solnic
force-pushed
the
e2e-test-setup
branch
3 times, most recently
from
76a9bbf to
e4724c2
Compare
This enables using top-level dir as a place to run rake tasks etc. too without warnings about duped gems in Gemfiles.
solnic
force-pushed
the
e2e-test-setup
branch
2 times, most recently
from
7037553 to
269df71
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| }, | ||
| define: { | ||
| __RAILS_API_URL__: JSON.stringify(process.env.SENTRY_E2E_RAILS_APP_URL || 'http://localhost:4000') | ||
| } |
There was a problem hiding this comment.
Bug: Vite Environment Variable Prefix Issue
The Svelte app uses import.meta.env.SENTRY_DSN_JS, but this environment variable is not exposed to client-side code by Vite. Vite only exposes variables prefixed with VITE_ by default, causing the Sentry DSN to be undefined. This can be fixed by renaming the variable to VITE_SENTRY_DSN_JS or explicitly defining it in vite.config.js.
Additional Locations (1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reworks our devcontainer setup so that it uses pre-built base images grabbed from ghcr.io and enables running e2e tests easily both on CI and locally.
There's a top level setup now in the root dir under
specwhere we can write high-level cross-gem e2e tests.This is a solid foundation for building even more conveniences around development/debugging/testing in the future 🙂
To run e2e tests locally you can simply do:
#skip-changelog