Skip to content

Comments

fix: iOS native bridge option creation#1963

Closed
bitsandfoxes wants to merge 2 commits intomainfrom
fix/ios-native-bridge
Closed

fix: iOS native bridge option creation#1963
bitsandfoxes wants to merge 2 commits intomainfrom
fix/ios-native-bridge

Conversation

@bitsandfoxes
Copy link
Contributor

Fixes an issue reported in #1951 (comment)

<REDACTED>/data/jenkins/workspace/<REDACTED>/iOS/Build/iOS/Libraries/io.sentry.unity/SentryNativeBridge.m:37:9: error: performSelector names a selector which retains the object
   37 |         performSelector:@selector(initWithDict:didFailWithError:)
      |         ^
In module 'Sentry' imported from <REDACTED>/data/jenkins/workspace/<REDACTED>/iOS/Build/iOS/Libraries/io.sentry.unity/SentryNativeBridge.m:1:
<REDACTED>/Library/Developer/Xcode/DerivedData/Unity-iPhone-cseycvbiwfelbyekvlwxliadxfvi/Build/Intermediates.noindex/ArchiveIntermediates/Unity-iPhone/BuildProductsPath/Release-iphoneos/Sentry.framework/PrivateHeaders/SentryOptions+HybridSDKs.h:11:1: note: method 'initWithDict:didFailWithError:' declared here
   11 | - (_Nullable instancetype)initWithDict:(NSDictionary<NSString *, id> *)options
      | ^
1 error generated.

If I read that correctly, then this is due to the performSelector not respecting ARC rules properly.
Instead, we're creating the options now directly.

Copy link

@brustolin brustolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bitsandfoxes
Copy link
Contributor Author

Superseded by #1964

@bitsandfoxes bitsandfoxes deleted the fix/ios-native-bridge branch April 7, 2025 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants