Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Propagate traceId on platforms supported by sentry-native #2089

Merged
merged 28 commits into from
Apr 9, 2025

Conversation

bitsandfoxes
Copy link
Contributor

Propagating the traceId when running on platforms supported by sentry-native.

Copy link
Contributor

github-actions bot commented Mar 31, 2025

Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Propagate `traceId` on platforms supported by `sentry-native` ([#2089](https://github.com/getsentry/sentry-unity/pull/2089))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 0060e5c

@bitsandfoxes bitsandfoxes requested review from vaind and Flash0ver April 7, 2025 18:30
@bitsandfoxes bitsandfoxes force-pushed the feat/propagate-traceid-desktop branch from f961bec to 6265ac0 Compare April 9, 2025 10:05
CHANGELOG.md Outdated
@@ -4,6 +4,7 @@

### Features

- When running on Windows or Linux, the SDK now links errors and events originating on different layers (managed, native errors) via `trace ID` ([#2089](https://github.com/getsentry/sentry-unity/pull/2089))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: Could we merge both entries into a single entry linking both PRs, or do we prefer to have one entry per PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, we could just append the links to the PRs to the entry!

Base automatically changed from feat/propagate-traceid-android to main April 9, 2025 19:40
@bitsandfoxes bitsandfoxes merged commit 75d3996 into main Apr 9, 2025
9 of 14 checks passed
@bitsandfoxes bitsandfoxes deleted the feat/propagate-traceid-desktop branch April 9, 2025 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants