Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Rename internal SetupLogging to SetupUnityLogging #2096

Merged
merged 2 commits into from
Apr 3, 2025

Conversation

bitsandfoxes
Copy link
Contributor

This PR renames the internal extension-method SetupLogging to SetupUnityLogging on the SentryUnityOptions.

Context

With getsentry/sentry-dotnet#4026 and release 5.5.0 the Sentry .NET SDK made its internals visible to the Unity SDK. This causes the extension method to get skipped and instead of

internal static void SetupLogging(this SentryUnityOptions options)

the actual SetupLogging on the SentryOptions gets called, creating a ConsoleLogger instead.

#skip-changelog

@bitsandfoxes bitsandfoxes merged commit cac2a68 into main Apr 3, 2025
71 of 78 checks passed
@bitsandfoxes bitsandfoxes deleted the fix/internalization branch April 3, 2025 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants