fix(hybridcloud) Move cache clearing for sentryapps to a task #77791
+57
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clearing the region cache for large sentryapps is timing out due to query timeouts. Moving the RPC operations into a task will allow the outbox to be processed more efficiently. If the clear cache task is dropped, caches will naturally expire due to TTL. Fixes SENTRY-3DEZ
github-actions
bot
added
the
Scope: Backend
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #77791 +/- ##
==========================================
- Coverage 78.09% 78.09% -0.01%
==========================================
Files 6987 6987
Lines 309826 309832 +6
Branches 50696 50697 +1
==========================================
+ Hits 241962 241966 +4
- Misses 61391 61393 +2
Partials 6473 6473 |
GabeVillalobos
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clearing the region cache for large sentryapps is timing out due to query timeouts. Moving the RPC operations into a task will allow the outbox to be processed more efficiently. If the clear cache task is dropped, caches will naturally expire due to TTL.
Fixes SENTRY-3DEZ