fix(2fa): do not allow to enforce 2FA when having recovery codes only #77798
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when an owner has only recovery codes (backup interface), this still allows them to enforce 2FA for the organization what is wrong.
The requirement of having a proper 2FA method was implemented in #6812 but it was broken during HC changes in #44219.
The
has_2fa()
method has a different semantic in the regional silo:sentry/src/sentry/users/services/user/model.py
Lines 124 to 125 in e362bf5
vs control silo:
sentry/src/sentry/users/models/user.py
Lines 239 to 242 in e362bf5