fix(autofix): Make starting UI more clear #77802
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
Instead of attempting to reconstruct the hostname from the url_domain
and url_domain_suffix use urlprase to extract the hostname.
The url_domain{,_suffix} are used for different de-duping reasons.
I misread the stacktrace and the escape needs to be when reading the file, not opening it. Bailing early feels like the simplest solution, and will be easy to remove later today. Fixes SENTRY-3CS1
Converts the tabs to folding data sections. They are rendered as is, and we can introduce new designs if we have more time later on, but for now, styling and text sizes are the same.    **todo** - [x] Add tests for their new location - [ ] Figure out subrouting so directly linking to `/merged` and `/similar` does something expected --------- Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
Paving the way for uptime alert creation, navigating to /new/uptime will render the uptime form and will eventually be accessible from the wizard
- Need to look into why, but looks like the default tags list is different in EAP?
- This adds the sampling columns to help explore the extrapolation data better, We should not use this in the UI and its just for testing --------- Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
Requires #77749 first, this implements the LLM monitoring frontend using EAP instead of metrics.
…egrations (#77094)" This reverts commit 28cdab1. Co-authored-by: RyanSkonnord <[email protected]>
github-actions
bot
added
the
Scope: Backend
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
|
lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor visual UI changes to make the "waiting to start" state more clear.