Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hybridcloud) Add networking failure metrics #77811

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

markstory
Copy link
Member

While we have long had metrics for response codes, we've not had metrics on networking errors. I'd like to gain more visiblity into these.

While we have long had metrics for response codes, we've not had metrics
on networking errors. I'd like to gain more visiblity into these.
@markstory markstory requested a review from a team as a code owner September 19, 2024 20:51
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Sep 19, 2024
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/hybridcloud/rpc/service.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #77811       +/-   ##
===========================================
+ Coverage   57.32%   78.07%   +20.75%     
===========================================
  Files        6980     6991       +11     
  Lines      309409   309923      +514     
  Branches    50636    50708       +72     
===========================================
+ Hits       177375   241986    +64611     
+ Misses     127171    61460    -65711     
- Partials     4863     6477     +1614     

@markstory markstory merged commit d01c95e into master Sep 20, 2024
50 of 51 checks passed
@markstory markstory deleted the chore-rpc-client-metrics branch September 20, 2024 14:07
@github-actions github-actions bot locked and limited conversation to collaborators Oct 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants