-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
feat(anomaly detection):preview chart proxy api endpoint #77813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #77813 +/- ##
===========================================
+ Coverage 61.67% 75.93% +14.25%
===========================================
Files 6970 6982 +12
Lines 309249 309845 +596
Branches 50629 50694 +65
===========================================
+ Hits 190730 235278 +44548
+ Misses 112656 67834 -44822
- Partials 5863 6733 +870 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
api design lgtm
) | ||
def _format_historical_data(self, data) -> list[TimeSeriesPoint] | None: | ||
""" | ||
Format EventsStatsData into the format that the Seer API expects. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly as a note to myself, but after my other pr lands we should be able to consolidate these functions and only have one. Mine serializes the data to get it into the format you're expecting here, but I can just do that before calling the function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Consider my comments non-blocking, but a few small things to think through.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some non-blocking comments but otherwise looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for my 🟩
Build out the preview chart proxy endpoint. Calls a placeholder function.