Skip to content

feat(anomaly detection):preview chart proxy api endpoint #77813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 20, 2024

Conversation

mifu67
Copy link
Contributor

@mifu67 mifu67 commented Sep 19, 2024

Build out the preview chart proxy endpoint. Calls a placeholder function.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Sep 19, 2024
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 83.67347% with 8 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...try/api/endpoints/organization_events_anomalies.py 81.81% 4 Missing and 4 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #77813       +/-   ##
===========================================
+ Coverage   61.67%   75.93%   +14.25%     
===========================================
  Files        6970     6982       +12     
  Lines      309249   309845      +596     
  Branches    50629    50694       +65     
===========================================
+ Hits       190730   235278    +44548     
+ Misses     112656    67834    -44822     
- Partials     5863     6733      +870     

@mifu67 mifu67 marked this pull request as ready for review September 20, 2024 16:58
@mifu67 mifu67 requested a review from a team as a code owner September 20, 2024 16:58
Copy link
Member

@iamrajjoshi iamrajjoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

api design lgtm

)
def _format_historical_data(self, data) -> list[TimeSeriesPoint] | None:
"""
Format EventsStatsData into the format that the Seer API expects.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly as a note to myself, but after my other pr lands we should be able to consolidate these functions and only have one. Mine serializes the data to get it into the format you're expecting here, but I can just do that before calling the function.

Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Consider my comments non-blocking, but a few small things to think through.

Copy link
Member

@ceorourke ceorourke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some non-blocking comments but otherwise looks good!

Copy link
Contributor

@schew2381 schew2381 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for my 🟩

@mifu67 mifu67 enabled auto-merge (squash) September 20, 2024 17:54
@mifu67 mifu67 merged commit caa42ff into master Sep 20, 2024
49 checks passed
@mifu67 mifu67 deleted the mifu67/preview-proxy-api branch September 20, 2024 18:25
@github-actions github-actions bot locked and limited conversation to collaborators Oct 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants