Skip to content

feat(nav): Upgrade org dropdown to new components #86824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 12, 2025

Conversation

malwilley
Copy link
Member

@malwilley malwilley commented Mar 11, 2025

Copies over the SidebarDropdown component from the old sidebar and rebuilds it using <DropdownMenu />

CleanShot 2025-03-11 at 14 19 24

@malwilley malwilley requested a review from a team March 11, 2025 18:27
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 11, 2025
@malwilley malwilley requested a review from evanpurkhiser March 11, 2025 20:23
@malwilley malwilley force-pushed the malwilley/feat/nav-new-org-dropdown branch from 220991c to adff20f Compare March 11, 2025 21:06
Copy link

codecov bot commented Mar 11, 2025

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
9697 2 9695 4
View the top 2 failed test(s) by shortest run time
OrgDropdown displays org info and links
Stack Traces | 0.167s run time
TestingLibraryElementError: Unable to find an element with the text: Organization Name. This could be because the text is broken up by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more flexible.

Ignored nodes: comments, script, style
...
    at Object.getElementError (.../sentry/sentry/node_modules/@.../dom/dist/config.js:37:19)
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:76:38
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:52:17
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:95:19
    at Object.<anonymous> (.../components/nav/orgDropdown.spec.tsx:25:40)
OrgDropdown can switch orgs
Stack Traces | 1.2s run time
Error: Unable to find role="link" and name `/Org 1/`

Ignored nodes: comments, script, style
...
    at waitForWrapper (.../sentry/sentry/node_modules/@.../dom/dist/wait-for.js:163:27)
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:86:33
    at Object.<anonymous> (.../components/nav/orgDropdown.spec.tsx:112:46)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@malwilley malwilley merged commit d8e4af7 into master Mar 12, 2025
41 checks passed
@malwilley malwilley deleted the malwilley/feat/nav-new-org-dropdown branch March 12, 2025 21:54
jan-auer added a commit that referenced this pull request Mar 13, 2025
* master: (45 commits)
  update security.txt (#86698)
  feat(onboarding): Add acc. test for loading docs and deletion modal changes (#86866)
  fix(issues): Always add extra day to default selection (#86965)
  🔧 chore(aci): move alert context out of workflow engine (#86926)
  test(react19): Fix create org acceptance test (#86960)
  ref(react19): Replace remaining ReactText type (#86957)
  chore: add comment to managedNote (#86955)
  deps(ui): Upgrade babel, core-js (#86948)
  fix(autofix): Attempt fix at trace connected queries (#86952)
  chore(issue-details): Add flag for access to the tour (#86943)
  feat(flagpole): Add a project's platform as context (#86930)
  fix(ourlogs): Small ux fixes for logs on issues (#86939)
  feat(ourlogs): Make traceids linkable (#86941)
  chore: gsAdmin codeowners (#86945)
  feat(ui): Add chart back to Releases drawer (#86889)
  feat(nav): Upgrade org dropdown to new components (#86824)
  🔧 chore(aci): move alert context out of workflow engine (#86924)
  fix(sentry apps): Empty string in component errors should not disable issue UI (#86937)
  fix(insights): Display dash for missing HTTP methods (#86940)
  feat(nav): Add 'give feedback' item to help menu (#86944)
  ...
Copy link

sentry-io bot commented Mar 18, 2025

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ Error: �[2mexpect(�[22m�[31melement�[39m�[2m).toHaveAttribute(�[22m�[32m�[32m"href"�[39m�[32m�[39m�[2m, �[22m�[32m�[32m"/settings/org-slug/"�[39m�[32m�[39m�[2m) // element.getAttribute("href") === "/settings/org-slug/"�[22m Object.?(orgDropdown.spec.tsx) View Issue

Did you find this useful? React with a 👍 or 👎

@github-actions github-actions bot locked and limited conversation to collaborators Apr 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants