Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nav): Upgrade org dropdown to new components #86824

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

malwilley
Copy link
Member

@malwilley malwilley commented Mar 11, 2025

Copies over the SidebarDropdown component from the old sidebar and rebuilds it using <DropdownMenu />

CleanShot 2025-03-11 at 14 19 24

@malwilley malwilley requested a review from a team March 11, 2025 18:27
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 11, 2025
@malwilley malwilley requested a review from evanpurkhiser March 11, 2025 20:23
@malwilley malwilley force-pushed the malwilley/feat/nav-new-org-dropdown branch from 220991c to adff20f Compare March 11, 2025 21:06
Copy link

codecov bot commented Mar 11, 2025

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
9697 2 9695 4
View the top 2 failed test(s) by shortest run time
OrgDropdown displays org info and links
Stack Traces | 0.167s run time
TestingLibraryElementError: Unable to find an element with the text: Organization Name. This could be because the text is broken up by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more flexible.

Ignored nodes: comments, script, style
...
    at Object.getElementError (.../sentry/sentry/node_modules/@.../dom/dist/config.js:37:19)
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:76:38
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:52:17
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:95:19
    at Object.<anonymous> (.../components/nav/orgDropdown.spec.tsx:25:40)
OrgDropdown can switch orgs
Stack Traces | 1.2s run time
Error: Unable to find role="link" and name `/Org 1/`

Ignored nodes: comments, script, style
...
    at waitForWrapper (.../sentry/sentry/node_modules/@.../dom/dist/wait-for.js:163:27)
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:86:33
    at Object.<anonymous> (.../components/nav/orgDropdown.spec.tsx:112:46)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants