feat(ui): Make release bubble padding configurable #86841
+54
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We will need to configure different bubble styles when on different charts. This PR makes the padding configurable if needed. It also removes left padding from first bubble and right padding from last padding.
github-actions
bot
added
the
Scope: Frontend
billyvg
force-pushed
the
ref-ui-configurable-release-bubble-padding
branch
from
bfb5f1d to
0241175
Compare
billyvg
changed the title
<BarChart>
billyvg
commented
Mar 11, 2025
Comment on lines
226
to
234
| // bubbleStartX bubbleEndX | ||
| // | | | ||
| // v v | ||
| // ---------------- ---------------- | ||
| // | | | | | ||
| // ---------------- ---------------- | ||
| // ^ ^ | ||
| // |--| | ||
| // bubblePadding.x |
There was a problem hiding this comment.
note my artisanal ascii art
| @@ -1,10 +1,8 @@ | |||
| export const BUBBLE_SERIES_ID = '__release_bubble__'; | |||
| export const BUBBLE_AREA_SERIES_ID = '__release_bubble_area__'; | |||
| export const DEFAULT_BUBBLE_SIZE = 12; | |||
| export const DEFAULT_BUBBLE_SIZE = 4; | |||
There was a problem hiding this comment.
Previously, the bubble size was the entire height including whitespace around it. This was because I started w/ the chart configuration and calculated everything else based on that.
I inverted this so that we define the actual bubble pixel height and calculate the chart offsets based on that + padding.
|
|
||
| // "padding" around the bubbles as it is drawn on canvas vs CSS, this may need | ||
| // to move into `renderReleaseBubble` if it needs to be customizable | ||
| export const RELEASE_BUBBLE_Y_PADDING = 8; | ||
| export const RELEASE_BUBBLE_Y_HALF_PADDING = RELEASE_BUBBLE_Y_PADDING / 2; |
There was a problem hiding this comment.
calculate this since padding is now configurable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We may need to configure different bubble styles when on different charts. This PR makes the padding configurable if needed. It also removes left padding from first bubble and right padding from last padding and fixes the vertical alignment of the bubble as well.
ref #85775