Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(flags): add flag suggestions to discover searchbox #86842

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

aliu39
Copy link
Member

@aliu39 aliu39 commented Mar 11, 2025

Queries for feature flag keys (sorted by count) and values from discover searchbar. Suggestions are only displayed if

  • dataset=ERRORS or undefined. Flags only exist on the errors dataset.
  • feature-flag-autocomplete flag is enabled
  • there are >0 flags in the org

As in issues stream, flag keys are wrapped w/flags[""] to escape special characters reserved by the searchbox. They're unwrapped for value queries (for suggestions), but not for the search.

Screenshot 2025-03-11 at 2 21 34 PM

Sample search in prod: 0 results for session-replay-ui = false (a flag that is 100% true everywhere). This suggests the syntax already works w/discover search backend

Closes https://github.com/getsentry/team-replay/issues/552

@aliu39 aliu39 requested a review from a team as a code owner March 11, 2025 21:24
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 11, 2025
@aliu39 aliu39 changed the title feat(flags): add flag suggestions to discover searchbar feat(flags): add flag suggestions to discover searchbox Mar 11, 2025
Copy link

codecov bot commented Mar 11, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
9691 1 9690 4
View the top 1 failed test(s) by shortest run time
AutofixSteps renders output stream when last step is processing
Stack Traces | 1.08s run time
Error: Unable to find an element with the text: Processing message. This could be because the text is broken up by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more flexible.

Ignored nodes: comments, script, style
...
    at waitForWrapper (.../sentry/sentry/node_modules/@.../dom/dist/wait-for.js:163:27)
    at Object.<anonymous> (.../events/autofix/autofixSteps.spec.tsx:91:44)
    at Promise.then.completed (.../sentry/sentry/node_modules/jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../sentry/sentry/node_modules/jest-circus/build/utils.js:231:10)
    at _callCircusTest (.../sentry/sentry/node_modules/jest-circus/build/run.js:316:40)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)
    at _runTest (.../sentry/sentry/node_modules/jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (.../sentry/sentry/node_modules/jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../sentry/sentry/node_modules/jest-circus/build/run.js:121:9)
    at run (.../sentry/sentry/node_modules/jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../sentry/sentry/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../sentry/sentry/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../sentry/sentry/node_modules/jest-runner/build/runTest.js:367:16)
    at runTest (.../sentry/sentry/node_modules/jest-runner/build/runTest.js:444:34)
    at Object.worker (.../sentry/sentry/node_modules/jest-runner/build/testWorker.js:106:12)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@aliu39 aliu39 requested review from a team and cmanallen March 11, 2025 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant