Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(shared-views): Only use positions from starred views #86848

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MichaelSun48
Copy link
Member

This PR makes it so that the GET endpoint only uses the position column from the GroupSearchViewStarred endpoint, rather than from GroupSearchView.

This was previously gated via a feature flag that only I have had access to, and it works perfectly fine. After this change, we should be able to safely drop the position column from the GroupSearchView table and clear out any usages.

depends on #86737 to be merged and run

@MichaelSun48 MichaelSun48 requested a review from a team as a code owner March 11, 2025 21:43
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 11, 2025
Copy link

codecov bot commented Mar 11, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
2080 1 2079 51
View the top 1 failed test(s) by shortest run time
tests.acceptance.test_organization_integration_detail_view.OrganizationIntegrationDetailView test_example_installation
Stack Traces | 33.1s run time
#x1B[1m#x1B[31mtests/acceptance/test_organization_integration_detail_view.py#x1B[0m:48: in test_example_installation
    assert integration
#x1B[1m#x1B[31mE   assert None#x1B[0m

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants