feat(shared-views): Only use positions from starred views #86848
+5
−47
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it so that the GET endpoint only uses the
position
column from theGroupSearchViewStarred
endpoint, rather than fromGroupSearchView
.This was previously gated via a feature flag that only I have had access to, and it works perfectly fine. After this change, we should be able to safely drop the
position
column from the GroupSearchView table and clear out any usages.depends on #86737 to be merged and run