feat(insights): add back session health onboarding #86849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
michellewzhang
changed the title
michellewzhang
changed the title
michellewzhang
changed the title
michellewzhang
commented
Mar 11, 2025
static/app/views/insights/common/components/modulesOnboarding.tsx
Outdated
Show resolved
Hide resolved
billyvg
reviewed
Mar 11, 2025
static/app/views/insights/common/components/modulesOnboarding.tsx
Outdated
Show resolved
Hide resolved
billyvg
reviewed
Mar 11, 2025
static/app/views/insights/common/components/modulesOnboarding.tsx
Outdated
Show resolved
Hide resolved
billyvg
approved these changes
Mar 11, 2025
billyvg
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the onboarding SDK icons for insights were just mapping the SDK name (the
PlatformKey) to an uppercase version of it, which doesn't work super well for iOS or .NET for example. we already have access to thePlatformIntegrationtype which gives us a handy name reference, so use that instead.before:
Screen.Recording.2025-03-11.at.2.07.51.PM.mov
after:
Screen.Recording.2025-03-11.at.2.06.54.PM.mov
the SDKs shown in the session health onboarding are based on the docs: https://docs.sentry.io/product/releases/setup/
closes #86837