Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEVINFRA-630: record "rerun" test results #86850

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

DEVINFRA-630: record "rerun" test results #86850

wants to merge 4 commits into from
+37 −0

Conversation

bukzor
Copy link
Contributor

@bukzor bukzor commented Mar 11, 2025

blocked by: getsentry/devinfra-metrics#77

@bukzor bukzor requested a review from IanWoodard March 11, 2025 21:48
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 11, 2025
@bukzor bukzor requested a review from asottile-sentry March 11, 2025 21:50
asottile-sentry
asottile-sentry reviewed Mar 11, 2025
View reviewed changes
Copy link
Member

@asottile-sentry asottile-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add this file to the stronglist at the bottom of pyproject.toml and add types

src/sentry/testutils/pytest/json_report_reruns.py Outdated
json_tests: None | dict[str, object] = None

def pytest_plugin_registered(self, plugin, manager):
del manager
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't use pylint

@bukzor
Copy link
Contributor Author

bukzor commented Mar 11, 2025 •
edited
Loading

can you add this file to the stronglist at the bottom of pyproject.toml and add types

I'll try. The types are entirely fucked I think :(

Done. It wasn't as bad as expected :)

@bukzor bukzor requested a review from a team as a code owner March 11, 2025 22:03
@bukzor bukzor requested a review from asottile-sentry March 11, 2025 22:05
asottile-sentry
asottile-sentry reviewed Mar 11, 2025
View reviewed changes
Copy link
Member

@asottile-sentry asottile-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty sure this still doesn't pass typing -- did you run mypy on this?

@bukzor bukzor requested a review from a team as a code owner March 11, 2025 22:17
@bukzor bukzor requested a review from asottile-sentry March 11, 2025 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IanWoodard IanWoodard Awaiting requested review from IanWoodard

@asottile-sentry asottile-sentry Awaiting requested review from asottile-sentry

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bukzor @asottile-sentry