chore(anomaly detection): Add logging and metrics when agg value is none #86853
+11
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
mifu67
approved these changes
Mar 11, 2025
ram-senth
reviewed
Mar 11, 2025
| @@ -53,6 +53,8 @@ def get_anomaly_data_from_seer( | |||
| or not snuba_query.time_window | |||
| or not aggregation_value | |||
| ): | |||
| metrics.incr("anomaly_detection.aggregation_value.none") | |||
| logger.warning("Aggregation value is none", extra=extra_data) | |||
There was a problem hiding this comment.
Should we add threshold_type, alert_rule.sensitivity, alert_rule.seasonality, snuba_query.time_window and aggregation_value to extra data? Also, should we check for None explicitly? With this check, we will have a warning if aggregation_value is 0?
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
❌ Your patch check has failed because the patch coverage (22.22%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #86853 +/- ##
===========================================
+ Coverage 33.16% 87.78% +54.62%
===========================================
Files 8288 9796 +1508
Lines 462060 554983 +92923
Branches 21798 21798
===========================================
+ Hits 153223 487217 +333994
+ Misses 308441 67370 -241071
Partials 396 396 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add logging when the aggregation value is none as we attempt to debug why we're missing sending data to Seer sometimes. Add a metric so we can keep track of how often this happens.