Skip to content

Skip flaky test: test_value_matches_positive #94877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

devinfra-flakiness[bot]
Copy link
Contributor

Please help us keep Sentry flake-free by merging this PR while a longer-term
resolution is implemented in issue #94876.

Test: tests/sentry/test_killswitches.py::test_value_matches_positive[cfg2-value2]

Statistics over the last 30 days:
* Runs Recorded: 786
* Flakes Failed: 0 (0%)
* Flakes Retried: 74 (9.414758%)

Example Flakes:


See also:
Flaky Test Policy & Responsibilities

@devinfra-flakiness devinfra-flakiness bot added Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests system:flakiness Devinfra Flakiness Burndown labels Jul 3, 2025
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Overly Broad Test Skip Reduces Coverage

The pytest.mark.skip decorator was applied to an entire parametrized test function, causing all its test cases (e.g., 8) to be skipped. The intent was to skip only the specific flaky test case test_value_matches_positive[cfg2-value2]. This overly broad skip unnecessarily reduces test coverage and could mask regressions in the non-flaky cases.

tests/sentry/test_killswitches.py#L19-L20

@pytest.mark.skip(reason="flaky: #94876")

Fix in Cursor


Was this report helpful? Give feedback by reacting with 👍 or 👎

Copy link

codecov bot commented Jul 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #94877      +/-   ##
==========================================
+ Coverage   85.34%   87.89%   +2.54%     
==========================================
  Files       10448    10448              
  Lines      604146   604147       +1     
  Branches    23530    23530              
==========================================
+ Hits       515593   530991   +15398     
+ Misses      88189    72792   -15397     
  Partials      364      364              

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
system:flakiness Devinfra Flakiness Burndown Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants