chore(tasks) Remove autoreload option from taskworker #96486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we implemented signal handlers for SIGTERM/SIGINT --autoreload has not worked as autoreload runs the worker in non-main thread where signals handlers cannot be registered. Removing `--autoreload` lets `devservices foreground taskworker` work again. I'll revisit autoreload in the future when I figure out how to get it to play nicely with multiprocessing.
github-actions
bot
added
the
Scope: Backend
hubertdeng123
approved these changes
Jul 25, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #96486 +/- ##
==========================================
- Coverage 83.83% 83.72% -0.11%
==========================================
Files 10642 10643 +1
Lines 614424 614468 +44
Branches 24127 24127
==========================================
- Hits 515087 514461 -626
- Misses 98956 99626 +670
Partials 381 381 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we implemented signal handlers for SIGTERM/SIGINT --autoreload has not worked as autoreload runs the worker in non-main thread where signals handlers cannot be registered. Removing
--autoreloadletsdevservices foreground taskworkerwork again.I'll revisit autoreload in the future when I figure out how to get it to play nicely with multiprocessing.