SDK-2771: Introduce auth token support for the IDV sandbox #506
+31
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in requests, instead of signed requests
MrBurtyyy
force-pushed
the
SDK-2771-SANDBOX
branch
from
bea81f3 to
320c6fa
Compare
MrBurtyyy
changed the title
|
irotech
reviewed
Dec 15, 2025
|
|
||
| private static final Logger LOGGER = LoggerFactory.getLogger(Builder.class); | ||
|
|
||
| private String authenticationToken; |
Collaborator
There was a problem hiding this comment.
Suggested change
| private String authenticationToken; | |
| private String authToken; |
for consistency?
Comment on lines
+140
to
+146
| if (authenticationToken == null) { | ||
| validateForSignedRequest(); | ||
| return new DocScanSandboxClient(sdkId, new DocsSignedRequestStrategy(keyPair, sdkId), new ObjectMapper(), new YotiHttpRequestBuilderFactory()); | ||
| } else { | ||
| validateAuthToken(); | ||
| return new DocScanSandboxClient(sdkId, new AuthTokenStrategy(authenticationToken), new ObjectMapper(), new YotiHttpRequestBuilderFactory()); | ||
| } |
Collaborator
There was a problem hiding this comment.
Instead of creating new ObjectMapper and YotiHttpRequestBuilderFactory on every invocation they could be instantiated only once making them static final fields within this class
private static final ObjectMapper MAPPER = new ObjectMapper();
private static final YotiHttpRequestBuilderFactory REQUEST_BUILDER_FACTORY = new YotiHttpRequestBuilderFactory();
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bucky-boy #504 will need merging, and this PR rebasing before it is ready to go in