Fix typing for select
#7572
Open
Fix typing for select
#7572
+1,015
−620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErichDonGubler
force-pushed
the
auto-type-conv-for-select-args
branch
from
991856b to
cfd29df
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
ErichDonGubler
force-pushed
the
auto-type-conv-for-select-args
branch
from
cfd29df to
c6dcb79
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
ErichDonGubler
force-pushed
the
auto-type-conv-for-select-args
branch
from
c6dcb79 to
62c8609
Compare
1 task
ErichDonGubler
force-pushed
the
auto-type-conv-for-select-args
branch
2 times, most recently
from
2de9a82 to
83ad8bb
Compare
This comment was marked as resolved.
This comment was marked as resolved.
ErichDonGubler
changed the title
selectselect
ErichDonGubler
force-pushed
the
auto-type-conv-for-select-args
branch
2 times, most recently
from
db91e44 to
2f271ab
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
ErichDonGubler
force-pushed
the
auto-type-conv-for-select-args
branch
2 times, most recently
from
d792084 to
817989b
Compare
This comment was marked as resolved.
This comment was marked as resolved.
ErichDonGubler
force-pushed
the
auto-type-conv-for-select-args
branch
2 times, most recently
from
6db2cc1 to
6e62829
Compare
1 task
ErichDonGubler
force-pushed
the
auto-type-conv-for-select-args
branch
from
6e62829 to
88fa2bb
Compare
ErichDonGubler
commented
May 2, 2025
|
|
||
| let select_single_component = | ||
| |this: &mut Self, reject_scalar, reject, accept, condition| { | ||
| let accept = this.cast(accept, reject_scalar, span)?; |
There was a problem hiding this comment.
Migrated from #7602 (comment): @jimblandy was wondering if we really needed cast here. So far as I can tell...yes.
ErichDonGubler
commented
May 2, 2025
naga/src/valid/expression.rs
Outdated
There was a problem hiding this comment.
todo: Drop changes here. I'd originally changed this code, with a refactor that's no longer needed.
ErichDonGubler
force-pushed
the
auto-type-conv-for-select-args
branch
2 times, most recently
from
dd40727 to
1881436
Compare
ErichDonGubler
changed the title
selectselect
ErichDonGubler
force-pushed
the
auto-type-conv-for-select-args
branch
from
1881436 to
4c8503b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Depends on feat(naga): constant evaluation forselect#7602.select#7538.Testing
Tests have been added, as well as a test run against
webgpu:shader,execution,expression,call,builtin,select:*in a locally modified Firefox.Squash or Rebase?
rebase plz
Checklist
CHANGELOG.mdentry.