-
Notifications
You must be signed in to change notification settings - Fork 1k
Support Sliced 3D for ASTC #7577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Sliced 3D for ASTC #7577
Conversation
Adjusted after running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! Looks mostly good to me, some changes proposed in comments.
Would be great to have a test for this that generates astc textures, but iirc we don't have that for other compressed formats either :/
Co-authored-by: Andreas Reich <[email protected]>
@Wumpf Thank you very much for the review. Besides accepting the suggestion, I made a commit to address the other ones. For testing in general for compression maybe a tracking issue can be created however webgpu-samples already include an astc-compressed example data (and CTS covers ASTC Sliced 3D), or I can try to help in a consecutive PR to have it generate directly inside repo. Appreciated. Hope the commits help. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much! looking great
We unfortunately don't run webgpu conformance tests in-repo right now, but Mozilla is running it on their side so true, that should give us some coverage already. Would be still nice to have a dedicated unit test on our side, but as mentioned that's true for all other compression formats as well. Created a ticket about that here
@Wumpf thank you, I appreciate the kind review & merge! |
Connections
Fixes #7576
Description
This PR aims to enable
"texture-compression-astc-sliced-3d"
for backends that support ASTC (such as excluding D3D12).If any aspects could be improved to make it more suitable for the project, please let me know, and I will adjust it. Thank you very much in advance!
Testing
Mainly
cargo xtask test
.Squash or Rebase?
Squash
Checklist
cargo fmt
.taplo format
.cargo clippy --tests
. If applicable, add:--target wasm32-unknown-unknown
cargo xtask test
to run tests.CHANGELOG.md
entry.