Make wgpu-core's copy_buffer_to_buffer size
parameter optional
#7659
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the
size
parameter to wgpu-core'scopy_buffer_to_buffer
implementation optional. When the size is omitted, the copy spans from the source offset to the end of the source buffer.The goal here is to make the
size
parameter tocopyBufferToBuffer
optional in Firefox. https://bugzilla.mozilla.org/show_bug.cgi?id=1959728. We might be able to achieve this without changing the signature of wgpucopy_buffer_to_buffer
functions at all, but note thattrace::Command::CopyBufferToBuffer
is used to serialize the command between the content process and GPU process, so keepingsize
non-optional in that enum variant would significantly complicate things in Firefox.I didn't change the signature of
copy_buffer_to_buffer
on wgpu (non-core). That seemed like a fairly disruptive breaking change.Testing
No tests, right now, other than not breaking existing tests. This is covered by the WebGPU CTS although that's not currently running in the wgpu repo.
Squash or Rebase? Squash
Checklist
cargo fmt
.taplo format
.cargo clippy --tests
. If applicable, add:--target wasm32-unknown-unknown
cargo xtask test
to run tests.CHANGELOG.md
entry.