[d3d12 wgl] Upgrade to windows 0.61 crates
#8013
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
commented
Jul 27, 2025
Comment on lines
183
to
185
| /// Sum of the memory reserved by all memory blocks including unallocated regions, in bytes. | ||
| // XXX: Rename to total_capacity_bytes following the rename at https://github.com/Traverse-Research/gpu-allocator/pull/266? | ||
| pub total_reserved_bytes: u64, |
There was a problem hiding this comment.
CC @nical based on Traverse-Research/gpu-allocator#226 which got changed in Traverse-Research/gpu-allocator#266.
https://github.com/microsoft/windows-rs/releases/tag/0.61.0 The latest `windows 0.59` and `windows-core 0.59` crates were just released (strangely tagged `0.61`), including some minor code improvements for us. The MSRV has been bumped to `1.74`, but `wgpu` is already on `1.76` anyway.
MarijnS95
changed the title
windows 0.61 crateswindows 0.61-0.62 crates
MarijnS95
changed the title
windows 0.61-0.62 crateswindows 0.61 crates
MarijnS95
force-pushed
the
windows-0.61
branch
from
f4122da to
44e09d8
Compare
|
I would have used a version range to include the latest https://github.com/microsoft/windows-rs/releases/tag/69 release since |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Depends on #6876
Depends on Traverse-Research/gpu-allocator#288
Description
Uses the latest
windows 0.61andwindows-core 0.61releases.https://github.com/microsoft/windows-rs/releases/tag/63
Testing
Squash or Rebase?
squash
If your pull request contains multiple commits, please indicate whether
they need to be squashed into a single commit before they're merged,
or if they're ready to rebase onto
trunkas they stand. In thelatter case, please ensure that each commit passes all CI tests, so
that we can continue to bisect along
trunkto isolate bugs.Checklist
cargo fmt.taplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.mdentry.