-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[hal/dx12] Mesh Shaders #8110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
[hal/dx12] Mesh Shaders #8110
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Broadly looks good, I have some questions/concerns. I'm definitely going to want to do at least one more pass where I actually clone this locally to poke around.
mesh_pipeline_build(&ctx, None, BASIC_MESH, None, true); | ||
pub static MESH_PIPELINE_BASIC_MESH: GpuTestConfiguration = | ||
default_gpu_test_config(DrawType::Standard).run_sync(|ctx| { | ||
mesh_pipeline_build(&ctx, false, false, true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Too may bools here - can we use a enum(s)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tried to address this by using a struct, not sure its much of an improvement at all though.
# These use "-Fo" as an argument to DXC | ||
'examples/features/src/mesh_shader/mod.rs', | ||
'tests/tests/wgpu-gpu/mesh_shader/mod.rs', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should add "Fo" to the list of extend-words or identifiers, not block the whole shader.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that "Fo"->"Do" or "Fo"->"Go" or "Fo"->"To" etc are close enough on the keyboard and common enough that it would be worth more to keep Fo disallowed than to block it for a single function used in 2 files.
Co-authored-by: Connor Fitzgerald <[email protected]>
Co-authored-by: Connor Fitzgerald <[email protected]>
…name to shader compilers
…ggie70incorporated/wgpu into mesh-shading/dx12-backend
Connections
Addresses #7219, a sub-issue of #7197
Description
This adds a DX12 backend for mesh shaders
Current issues:
Testing
I have updated the mesh shader example to use DXILpassthrough to test this, and it works.
Squash or Rebase?
Squash
Checklist
cargo fmt
.taplo format
.cargo clippy --tests
. If applicable, add:--target wasm32-unknown-unknown
cargo xtask test
to run tests.CHANGELOG.md
entry.