test(cts): Enable some external texture tests #8901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
andyleiserson
force-pushed
the
jj-push-vzso
branch
from
e75a6ff to
62e4473
Compare
Deno changes: * Allow the application to request the `external-texture` feature, even though it is not exposed as an available feature. * Support external texture in bindings. (This is only intended to support cts_runner testing, it's not expected to actually be useful.) cts_runner and xtask changes: * Add `--enable-external-texture` argument to turn on the `external-texture` feature. * Add a new test list to be run with external texture enabled.
andyleiserson
force-pushed
the
jj-push-vzso
branch
from
62e4473 to
e1ea0d9
Compare
andyleiserson
changed the title
Contributor
Author
|
Whichever of this or #8936 lands second, can set |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some limited support for running external texture tests in deno (supported tests are ones that only exercise shader compilation or binding layouts without actually attempting to create an external texture).
Because Deno doesn't really support external textures, we can't turn this on across all of the CTS in CI, because it will introduce additional failures that are currently skipped. So this adds a new CTS suite for external texture, which gets run in the "Other" job on Mac and Windows.
Deno changes:
external-texturefeature, even though it is not exposed as an available feature.cts_runner and xtask changes:
--enable-external-textureargument to turn on theexternal-texturefeature.Squash or Rebase? Squash
Checklist
cargo fmt.taplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.mdentry.