fix(naga): Fix builtin metal imports #8954
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Might help with #5827.
Part of #4632.
See also related past issue gfx-rs/naga#1625.
Description
In gfx-rs/naga#289 / gfx-rs/naga#239,
using namespace metal;was removed, probably to help with avoiding name clashes. This causes issues on older platforms such as macOS 10.12 though, since a lot of types there doesn't seem to be builtin, and are only exposed as typedefs in themetalnamespace. Naga already contains a partial workaround for this (theusing metal::uint;).TODO: Solution?
Testing
cargo xtask teston a macOS 10.12 machine with #8953 applied gets us down to 11 failed tests.Checklist
cargo fmt.taplo format.cargo clippy --tests.cargo xtask testto run tests.CHANGELOG.mdentry.