Skip to content

Conversation

@andyleiserson
Copy link
Contributor

@andyleiserson andyleiserson commented Jan 31, 2026

Increases the value of the clippy large-error-threshold setting from the default of 128 to 192, and removes waivers for the associated lint (which get applied at module scope, because otherwise they need to be applied to each function that uses the big error type, and would allow any error in that module to be arbitrarily large).

Errors that are between 128 and 192 bytes:

  • back::pipeline_constants::PipelineConstantError
  • ValidationError
  • RenderBundleError, RenderPassError, CommandEncoderError
  • (SubmissionIndex, QueueSubmitError)

Testing
Clippy is still happy.

Squash or Rebase? Squash (bonus points if you correct large_error_threshold to large-error-threshold in the commit message)

Checklist

  • Run cargo fmt.
  • Run taplo format.
  • Run cargo clippy --tests. If applicable, add:
    • --target wasm32-unknown-unknown
  • Run cargo xtask test to run tests.
  • If this contains user-facing changes, add a CHANGELOG.md entry.

@andyleiserson andyleiserson changed the title clippy: Adjust large_error_threshold and remove waivers clippy: Adjust large-error-threshold and remove waivers Jan 31, 2026
@cwfitzgerald cwfitzgerald merged commit 2c9e77a into gfx-rs:trunk Jan 31, 2026
53 checks passed
@cwfitzgerald
Copy link
Member

I now demand my bonus points 😆

@andyleiserson andyleiserson deleted the jj-push-nuzt branch January 31, 2026 05:23
@andyleiserson
Copy link
Contributor Author

bonus-points

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants