Extended test coverage, break, unbreak #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added support for --format json-hash - Added support for new BlendMode s - Added support for slices - Added support for layer groups - Added user data support for layers - Un-Option meta.frame_tags in favor of an empty vec - Un-Option meta.layers in favor of an empty vec - Reduce future semver churning by making many structs/enums non-exhaustive - More test coverage
Contributor
|
Awesome, thanks! Sorry for the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created aseprite-test-data since I might want to write binary deserializers as well, which might warrant a separate crate. This PR integrates that test data and extends aseprite itself to support all the data therein:
--format json-hash(default) while maintaining support for--format json-arrayBlendModesAnd did some more... miscellanious changes, that might be more objectionable:
Optionmeta.frame_tags in favor of an empty vecOptionmeta.layers in favor of an empty vecPossible changes you might want, feel free to ask:
Optionifying of things?Celdata?Frametag->FrameTagsince we're in breaking things mode?