ggml-metal: fix memset range and temp buffer leaks #18221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ggml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Metal buffer range length (use element count) and release transient Metal buffers after set/get tensor sync to avoid unnecessary writes and lingering resources. Behavior stays the same, just avoids overruns and leaks.
Tests:
./ci/run.sh ./tmp/results ./tmp/mnt;./build/bin/llama-perplexity --model models/functiongemma-270m-it-Q4_K_M.gguf -f models-mnt/wikitext/wikitext-2-raw/wiki.test.raw -c 512 -b 256 --chunks 1 -ngl 99;./build/bin/llama-bench --model models/functiongemma-270m-it-Q4_K_M.gguf -ngl 99.AI: bug identified with Codex.