Skip to content

Conversation

@struct
Copy link
Contributor

@struct struct commented Dec 21, 2025

This adds a missing check for ggml_backend_buffer_is_rpc in serialize_tensor. When using the rpc server, the backend might pass a buffer to serialize_tensor via ggml_backend_rpc_buffer_type_get_alloc_size which incorrectly assumes it is an rpc buffer and casts a pointer (ctx) of type ggml_backend_rpc_buffer_context to it. In practice I think this just results in a nullptr crash.

test-backend-ops completes successfully

@struct struct requested a review from rgerganov as a code owner December 21, 2025 03:05
@github-actions github-actions bot added the ggml changes relating to the ggml tensor library for machine learning label Dec 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ggml changes relating to the ggml tensor library for machine learning

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant