Derive File-Accession mappings from AltAccessions - Update for Apollo Epic (GSI-2265) - #65
Merged
Merged
Conversation
Pull Request Test Coverage Report for Build 23894365116Details
💛 - Coveralls |
TheByronHimes
marked this pull request as ready for review
April 1, 2026 15:14
mephenor
requested changes
Apr 2, 2026
mephenor
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates WPS for changes introduced by Apollo - specifically with regard to research data file IDs and how we map them to externally visible accession numbers.
Old way: consume events that have
accession: str, file_id: UUID4.New way: consume events that have
id: str, pid: str, type: str, created: datetime, where pid=accession and id=file_id.Since Apollo's
AltAccessionsare published for other kinds of entities beyond the file IDs, we filter out any AltAccession event where the "type" field is notAltAccessionType.FILE_ID