Skip to content

cleanup: remove deprecated types #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ghosind
Copy link
Owner

@ghosind ghosind commented Jul 3, 2025

For #5

@ghosind ghosind requested a review from Copilot July 3, 2025 05:42
@ghosind ghosind added the enhancement New feature or request label Jul 3, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Cleanup PR to remove deprecated collection types and their associated tests, including legacy Go 1.23 variants.

  • Deleted the ConcurrentHashSet implementation and tests
  • Deleted the HashDictionary and ConcurrentHashDictionary implementations and tests
  • Removed Go 1.23-specific iterator variants for all deprecated types

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
set/concurrent_hashset_test.go Removed tests for deprecated ConcurrentHashSet
set/concurrent_hashset_pre_go123.go Removed pre-Go1.23 iterator implementation for ConcurrentHashSet
set/concurrent_hashset_go123.go Removed Go1.23 iterator implementation for ConcurrentHashSet
set/concurrent_hashset.go Removed deprecated ConcurrentHashSet implementation
dict/hashdict_test.go Removed tests for deprecated HashDictionary
dict/hashdict_go123.go Removed Go1.23 iterator implementation for HashDictionary
dict/hashdict.go Removed deprecated HashDictionary implementation
dict/concurrent_hashdict_test.go Removed tests for deprecated ConcurrentHashDictionary
dict/concurrent_hashdict_go123.go Removed Go1.23 iterator implementation for ConcurrentHashDictionary
dict/concurrent_hashdict.go Removed deprecated ConcurrentHashDictionary implementation

Copy link

codecov bot commented Jul 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.31%. Comparing base (5f0fa65) to head (8d71bd8).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
- Coverage   85.47%   81.31%   -4.17%     
==========================================
  Files          15        9       -6     
  Lines        1150      808     -342     
==========================================
- Hits          983      657     -326     
+ Misses        130      119      -11     
+ Partials       37       32       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant